Require 2FA for project and server deletion#123
Merged
Conversation
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
f0c09ed to
3f1a13d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Project deletion cascades through services, so it could previously bypass the service-level 2FA confirmation. Server deletion also lacked the same destructive-action protection. This makes the policy consistent without changing accounts that do not have 2FA enabled.
Validation
--noEmitpassedtests/two-factor.test.ts(5 tests)git diff --checkpassedReview note
The existing direct Better Auth TOTP throttling behavior is unchanged. This PR intentionally centralizes the currently merged service-delete policy without reintroducing the lockout implementation recently removed from
main.Related